-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PAGOPA-1359] fix: Update partially PAID case #77
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix junit and smoke before merge
update_code |
Update Code is failed. Please retry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
SonarCloud Quality Gate failed. 0 Bugs 94.9% Coverage The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Comment this PR with update_code to update |
List of Changes
checkDebtPositionStatus
is called inpaVerifyPaymentNotice
andmanageGetPaymentRequest
.The method
checkDebtPositionStatus
has been updated so that a payment position inPARTIALLY_PAID
state does not generate aPAGAMENTO_DUPLICATO
type exception. Specifically, the condition is replaced through a check on the payment option state, that is, the payment option must not be in statePO_PAID
.Add check on
PAA_PAGAMENTO_SCADUTO
exception: when Payment OptiondueDate
has been passed the payment is considered overdue.Motivation and Context
Fix check on
paVerifyPaymentNotice
SOAP action.How Has This Been Tested?
Local environment (gpd-payments) versus DEV instances (pgsql, gpd-core).
Integration test in UAT environment.
Screenshots (if appropriate):
Types of changes
Checklist: